Fix: Exit early from update_orthos() when orthos are off#1458
Merged
Conversation
mrariden
changed the title
update_orthos() when orthos are off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the orthos were off in the 3d gui and
update_orthos()was called, an error would occur becausezmaxwas unset:cellpose/cellpose/gui/gui3d.py
Lines 526 to 529 in c69c4ae
The fix is to return from
update_orthos()early when theorthobtnis unchecked. I just added a guard clause and unindented the block in the firstifstatement.